Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT LAND TESTING BENCHMARKING #1048

Closed
wants to merge 4 commits into from
Closed

DO NOT LAND TESTING BENCHMARKING #1048

wants to merge 4 commits into from

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Oct 2, 2024

This reverts commit 8305c2c.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.54%. Comparing base (f3837e8) to head (91127c6).

Files with missing lines Patch % Lines
.../contract/fieldcontract/EnsuresNonNullHandler.java 84.61% 2 Missing and 2 partials ⚠️
...c/main/java/com/uber/nullaway/NullabilityUtil.java 85.71% 0 Missing and 1 partial ⚠️
.../nullaway/dataflow/AccessPathNullnessAnalysis.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             master    #1048    +/-   ##
==========================================
  Coverage     87.54%   87.54%            
+ Complexity     2165     2138    -27     
==========================================
  Files            85       83     -2     
  Lines          7114     7003   -111     
  Branches       1386     1367    -19     
==========================================
- Hits           6228     6131    -97     
+ Misses          458      451     -7     
+ Partials        428      421     -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 2, 2024

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25  10.183 ± 0.105  ops/s
CaffeineBenchmark.compile         thrpt   25   3.798 ± 0.030  ops/s
DFlowMicroBenchmark.compile       thrpt   25  28.157 ± 0.276  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.457 ± 0.048  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25  10.383 ± 0.142  ops/s
CaffeineBenchmark.compile         thrpt   25   3.787 ± 0.036  ops/s
DFlowMicroBenchmark.compile       thrpt   25  28.468 ± 0.100  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.467 ± 0.027  ops/s

@msridhar msridhar closed this Oct 2, 2024
@msridhar msridhar deleted the test-bench branch October 2, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant