Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle records in targetTypeMatches #1061

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

msridhar
Copy link
Collaborator

Fixes #1059

@msridhar msridhar requested a review from yuxincs October 27, 2024 00:20
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.60%. Comparing base (8f4b928) to head (2842318).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...c/main/java/com/uber/nullaway/NullabilityUtil.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1061      +/-   ##
============================================
- Coverage     87.61%   87.60%   -0.02%     
- Complexity     2203     2204       +1     
============================================
  Files            85       85              
  Lines          7193     7195       +2     
  Branches       1415     1416       +1     
============================================
+ Hits           6302     6303       +1     
  Misses          456      456              
- Partials        435      436       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar enabled auto-merge (squash) October 27, 2024 18:57
@msridhar msridhar merged commit dc9cf0e into uber:master Oct 28, 2024
9 of 11 checks passed
@msridhar msridhar deleted the issue-1059 branch October 28, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression: unsupported element kind RECORD symbol
2 participants