Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump macos-10.15 to macos-12 #557

Closed
wants to merge 1 commit into from

Conversation

liby
Copy link

@liby liby commented Jul 23, 2022

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2022

CLA assistant check
All committers have signed the CLA.

@liby liby force-pushed the feature/dropping-macos-10-15 branch from b1b49ec to b96b091 Compare July 23, 2022 17:56
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (fde79d9) to head (b96b091).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #557   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files         105      105           
  Lines        7081     7081           
=======================================
  Hits         6131     6131           
  Misses        950      950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VivekPanyam
Copy link
Collaborator

Sorry about the delay! I didn't see this PR :/

For some reason, the macos GH Actions builds didn't run on this PR (and there's no way for me to "unlock" them). Can you try updating your branch to see if it gives me an option to trigger builds?

Thanks for the PR!

@liby
Copy link
Author

liby commented Sep 23, 2022

For some reason, the macos GH Actions builds didn't run on this PR (and there's no way for me to "unlock" them).

What can I do to update it? I see that my branch is up to date.

@VivekPanyam
Copy link
Collaborator

You can run git commit --amend on your branch locally and then force push the commit (git push -f origin [your branch name]).

This effectively replaces your original commit with a new one containing the same changes (which should retrigger builds).

Also, just a heads up, I manually tested this change and it breaks mac CI (with some virtualenv errors). You may need to update the virtualenv version in

${NEUROPOD_PYTHON_BINARY} -m pip install virtualenv==16.7.9

@liby liby closed this by deleting the head repository Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants