Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-tiny-popover (Fixes an issue with react and react-dom peer dependencies) #105

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

taifen
Copy link
Contributor

@taifen taifen commented Dec 18, 2023

We use npm and React 17 in our project, but @miksu/react-tiny-popover@3.5.1 adds React 16 and causes errors due to multiple React versions at runtime. So we had to add aliases for react and react-dom to the Webpack configuration. It would be nice if packages could work without them.

├── react-dom@17.0.2
└─┬ react-view@3.0.0
  ├─┬ @miksu/react-tiny-popover@3.5.1
  │ └── react-dom@16.14.0
  └─┬ react-simple-code-editor@0.13.1
    └── react-dom@17.0.2 deduped

This PR replaces @miksu/react-tiny-popover with the latest react-tiny-popover package.

Also, the contribution guidelines seem to be out of date, so I've replaced the yarn commands with ones I used but would appreciate feedback on this.

Thanks for the nice library!

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 9a6fd36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-view Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tajo tajo merged commit aba73c0 into uber:master Dec 18, 2023
3 checks passed
@tajo tajo mentioned this pull request Dec 18, 2023
@taifen taifen deleted the fix/react-tiny-popover-upgrade branch December 19, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants