Start here / app-grid yaru fixes #4072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
changed the title
…grid Without this every time we were rendering the icons we'd break it again
That's basically the start-here icon but with a better name respecting the shell session mode names
3v1n0
force-pushed
the
start-here-yaru-fixes
branch
from
edcf9da to
5211c02
Compare
|
Description updated |
Feichtmeier
approved these changes
Apr 17, 2024
Well, they wouldn't probably use the theme anyways if they're purists :), but in case they hopefully do it, it won't be there in the normal gnome session or yaru one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix symlinks and avoid confusions adding two different kinds.
So the problem here was that we had start-here icon that was symlinked to the app-grid one, thus when optimizing the first one we were overwriting the app-grid one. This is now fixed and I've added different variant of them.
So that it's still possible to use the default grid icon in ubuntu, but the dock will continue using micheleg/dash-to-dock#2197 the circle of friends by default, not to have to do an UIFe. But this can overridden by other distros and only affect installations with the dock running the ubuntu session.