Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log to stackify if we have a stackify API Key #405

Merged
merged 2 commits into from
Jan 19, 2024
Merged

log to stackify if we have a stackify API Key #405

merged 2 commits into from
Jan 19, 2024

Conversation

srkirkland
Copy link
Member

No description provided.

@srkirkland srkirkland requested a review from a team as a code owner January 19, 2024 18:17
sprucely
sprucely reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@sprucely sprucely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about logging configuration for jobs?

jSylvestre
jSylvestre approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@jSylvestre jSylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget there is the web and api projects
And probably check the test ones too.

@srkirkland
Copy link
Member Author

What about logging configuration for jobs?

good point!

@srkirkland
Copy link
Member Author

Don't forget there is the web and api projects And probably check the test ones too.

I don't understand

@srkirkland srkirkland merged commit c0b7f03 into master Jan 19, 2024
5 checks passed
@srkirkland srkirkland deleted the srk/stackify-logging branch January 19, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprucely sprucely sprucely approved these changes

@jSylvestre jSylvestre jSylvestre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srkirkland @jSylvestre @sprucely