fix ci windows

uchenily · May 16, 2024 · 5d27496 · 5d27496
1 parent 6df1bfe
commit 5d27496
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/uvio/core.hpp b/uvio/core.hpp
@@ -1,10 +1,7 @@
 #pragma once
 
-#if !defined(NOMINMAX) && defined(_WIN32)
-// https://github.com/randombit/botan/issues/1852
-#define NOMINMAX 1
-#include <windows.h>
-#endif
+// first
+#include "uvio/platform.hpp"
 
 #include "uvio/coroutine/task.hpp"
 #include "uvio/macros.hpp"

diff --git a/uvio/coroutine/task.hpp b/uvio/coroutine/task.hpp
@@ -1,10 +1,7 @@
 #pragma once
 
-#if !defined(NOMINMAX) && defined(_WIN32)
-// https://github.com/randombit/botan/issues/1852
-#define NOMINMAX 1
-#include <windows.h>
-#endif
+// first
+#include "uvio/platform.hpp"
 
 #include "uvio/debug.hpp"
 

diff --git a/uvio/platform.hpp b/uvio/platform.hpp
@@ -1,7 +1,16 @@
 #pragma once
 
+// define NOMINMAX in front of windows.h
+#if !defined(NOMINMAX) && defined(_WIN32)
+// https://github.com/randombit/botan/issues/1852
+#define NOMINMAX 1
+#endif
+
 #if defined(_WIN32)
+// winsock2.h in front of windows.h
 #include <winsock2.h>
+
+#include <windows.h>
 #else
 #include <netinet/in.h>
 #include <sys/socket.h>