Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mkdirs option to Writer#toFile #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isXander
Copy link

@isXander isXander commented Sep 2, 2021

No description provided.

@solonovamax
Copy link

Why is this not merged?

I don't see any issues with the PR, or anything blocking it.

@stale
Copy link

stale bot commented May 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs, but feel free to re-open a closed issue if needed.

@stale stale bot added the stale label May 24, 2023
nhubbard added a commit to nhubbard/konf that referenced this pull request Feb 10, 2024
Thank you to @isXander for this contribution!
@nhubbard
Copy link

I've forked Konf since it has become unfortunately unmaintained. I've applied your pull request to my fork. Hopefully you can finally use this feature!

nhubbard@f65f9bc

@stale stale bot removed the stale label Feb 10, 2024
@solonovamax
Copy link

hi, @nhubbard
are you planning on maintaining this fork of konf?
Because if so, I'd be interested in contributing to it, and continuing work on #48.

Additionally, I'd recommend against the name "konfig", as npryce/​konfig already exists, which uses that name.
A list of several existing kotlin config libraries can be found here, to avoid using the same name: https://kotlin.link/?q=config

@nhubbard
Copy link

nhubbard commented Feb 11, 2024

I'm looking to keep it at least at version parity with current Kotlin and Gradle builds. Most of my work on this was purely because I love using Konf and think it's a shame for it to languish.

Ideally, if I had unlimited time, I would keep all of the features from the previous build system and rewrite the tests from Spek to either Kotest or pure JUnit5, mostly due to the complete lack of development and the extremely slow execution speed of Spek 1.x. Maybe I would also do some refactoring, like moving back to the modular structure that I had to ditch because of build system constraints when moving to Gradle 8.

Thanks for the note on the name, I'll look into that tomorrow.

@nhubbard
Copy link

nhubbard commented Feb 11, 2024

Also, I have already integrated #48 into my fork, but it doesn't have any tests as of yet. I've added a reference to it into the README file in my most recent commit. I've also renamed the project back to Konf to prevent conflicting with the other repository and bumped the version to 2.0 to make the difference between the original and my fork more clear.

@nhubbard
Copy link

I've prepared most of the publishing setup and fixed the name. I have my namespace verified on Maven Central, but something is going on with a JIRA migration for Sonatype, which is making it impossible for me to publish artifacts. I've submitted a support ticket to Sonatype to try and fix it.

@solonovamax Feel free to fork my fork and start contributing. I'll review any changes you send in as I see them. Thanks!

@solonovamax
Copy link

Also, I have already integrated #48 into my fork, but it doesn't have any tests as of yet

uuhhhh.... unsure about the decision to merge it....

iirc it wasn't at all finished?
I have some unpublished changes to it as well on my laptop (I never bothered pushing them bc repo is dead and I didn't want to spend the time making a pr for a dead repo)

@solonovamax
Copy link

also, for build stuff, I'm willing to completely revamp the build.

I have a lot of experience battling with gradle to get it to do what I want.

@solonovamax
Copy link

do you have a matrix acc, so we could communicate somewhere that isn't issue comments?

@nhubbard
Copy link

@solonovamax

  • On the merge decision, I think it's okay for now because the tests still pass with it integrated, and the functionality is hidden behind a feature flag that's disabled by default.
  • For the build, I did reimplement most of the Gradle functionality, but publishing, JMH, Spotless, and the modular framework are currently missing. Sonatype did get back to me, but we'll have to discuss that privately, since there's some weird incompatibility between the new Maven Central submission process and the maven-publish plugin.
  • Matrix: @nhubbard:matrix.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants