Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 562: Revise pattern:patternExpression to be object property, and test for error form #566

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Issue 562: Revise pattern:patternExpression to be object property, and test for error form #566

merged 6 commits into from
Jun 5, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Nov 20, 2023 •
edited
Loading

This Pull Request resolves all requirements of Issue #562 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop-2.0.0
  • CI passes in UCO current unstable-2.0.0 branch (7dc3423)
  • CI passes in CASE current unstable-2.0.0 branch tracking UCO's unstable-2.0.0 as submodule (4aff9c9)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist
Add test that sh:datatype does not reference an OWL Class
ba77dea 
This test is spelled as a "Negative" constraint to avoid attempting to
hard-code a list of the recognized OWL "built-in" datatypes alongside
custom RDFS datatypes (such as UCO's vocabulary namespace members).

The anonymous node shape design pattern is documented in PR 564, commit
77cd47d.

This patch is known to fail CI at the moment because it catches the
error described in 562, but does not resolve that situation.  This patch
is provided now to prevent this implementation error pattern from
arising in the future.

References:
* #562
* 77cd47d

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added this to the UCO 2.0.0 milestone Nov 20, 2023
@ajnelson-nist
Revise pattern:patternExpression to be object property
177ab81 
This patch is implemented based on the early draft-state of Issue 550,
to correct the issue reported in Issue 562.

No effects were observed on Make-managed files.

References:
* #550
* #562

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist linked an issue Nov 20, 2023 that may be closed by this pull request
pattern:PatternExpression is erroneously encoded as a datatype and class #562
Closed
15 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request Nov 20, 2023
Closed
15 tasks
@ajnelson-nist
Revise sh:not structure in new sh:datatype test
5e193ae 
Commit ba77dea used a design pattern that I now believe is not
applicable.  This patch revises the new shape to the corrected from now
in PR 564.

No effects were observed on Make-managed files.

References:
* #562
* 6669aab

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Merge branch 'develop-2.0.0' into BugFix-Issue-562
1b5c305
@ajnelson-nist
Replace PatternExpression with xsd:string
9978efb 
No effects were observed on Make-managed files.

References:
* #562

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Add shape description
3c301b3 
No effects were observed on Make-managed files.

References:
* #562

Acked-by: Paul Brandt <paul@brandt.name>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Contributor Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review June 4, 2024 11:59
@ajnelson-nist ajnelson-nist requested a review from a team June 4, 2024 12:00
plbt5
plbt5 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@plbt5 plbt5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment of the property pattern:patternExpression, i.e.,
rdfs:comment "An explicit logical pattern expression."@en ,

is formulated as if the element that is addressed is a Class as opposed to a property. I consider this a minor issue not relevant for this review, hence my approval.

@plbt5 plbt5 merged commit 980fbb5 into develop-2.0.0 Jun 5, 2024
1 check passed
@plbt5 plbt5 deleted the BugFix-Issue-562 branch June 5, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
bug Change Proposal
Projects
None yet
Milestone
UCO 2.0.0
Development

Successfully merging this pull request may close these issues.

pattern:PatternExpression is erroneously encoded as a datatype and class
2 participants
@ajnelson-nist @plbt5