Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 573: Require target or source on an ObservableRelationship be Observables #575

Merged
merged 3 commits into from
May 1, 2024
Merged

Issue 573: Require target or source on an ObservableRelationship be Observables #575

merged 3 commits into from
May 1, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Dec 21, 2023 •
edited
Loading

This Pull Request resolves all backwards-incompatible requirements of Issue #573 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop-2.0.0
  • CI passes in UCO current unstable-2.0.0 branch (2f780d8)
  • CI passes in CASE current unstable-2.0.0 branch tracking UCO's unstable-2.0.0 as submodule (4ac6538)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)
  • PR 601 merged

@ajnelson-nist
Merge branch 'Feature-Issue-573' into Feature-Issue-573-2.0.0
02e05ee
@ajnelson-nist
Require target and source on an ObservableRelationship be Observables
de51af3 
No effects were observed on Make-managed files.

References:
* #573

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added this to the UCO 2.0.0 milestone Dec 21, 2023
@ajnelson-nist ajnelson-nist linked an issue Dec 21, 2023 that may be closed by this pull request
observable:ObservableRelationship should constrain the types on the objects it is relating #573
Closed
16 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request Apr 25, 2024
Closed
16 tasks
@ajnelson-nist ajnelson-nist marked this pull request as ready for review May 1, 2024 14:12
@ajnelson-nist
Copy link
Contributor Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist requested a review from a team May 1, 2024 14:12
@plbt5 plbt5 merged commit 78cfcc2 into develop-2.0.0 May 1, 2024
1 check passed
@plbt5 plbt5 deleted the Feature-Issue-573-2.0.0 branch May 1, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 2.0.0
Development

Successfully merging this pull request may close these issues.

observable:ObservableRelationship should constrain the types on the objects it is relating
2 participants
@ajnelson-nist @plbt5