Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up to Scala 2.13.12; Bump up sbt; Fix errors and warnings #22

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Bump up to Scala 2.13.12; Bump up sbt; Fix errors and warnings #22

merged 3 commits into from
Jan 16, 2024

Conversation

haoozi
Copy link
Contributor

@haoozi haoozi commented Jan 5, 2024

Bump up to Scala 2.13.12
Bump up SBT
Fix errors and warnings
Tested with RocketChip, produces identical output with master branch (same checksum)

@haoozi haoozi requested a review from sbeamer January 5, 2024 21:47
sbeamer
sbeamer requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@sbeamer sbeamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will miss the procedure syntax and omitting parentheses (auto-application), but yes, both are deprecated for 2.13.

Just one minor name concern. Thanks for making this.

src/main/scala/Harness.scala Outdated Show resolved Hide resolved
haoozi
haoozi commented Jan 11, 2024
View reviewed changes
Copy link
Contributor Author

@haoozi haoozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harnessConnect is mistakenly renamed to ections. Revert back

src/main/scala/Compiler.scala Outdated Show resolved Hide resolved
@haoozi
Update src/main/scala/Compiler.scala
20c474a 
harnessConnect is mistakenly renamed to ections.
@haoozi
Update src/main/scala/Harness.scala
6fd7213 
harnessConnect is mistakenly renamed to ections.
@sbeamer sbeamer merged commit 9167e79 into ucsc-vama:master Jan 16, 2024
1 check passed
@sbeamer
Copy link
Contributor

sbeamer commented Jan 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbeamer sbeamer sbeamer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haoozi @sbeamer