Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar #15

Open
ayan-b opened this issue Mar 12, 2019 · 4 comments
Open

Add progress bar #15

ayan-b opened this issue Mar 12, 2019 · 4 comments

Comments

@ayan-b
Copy link
Collaborator

ayan-b commented Mar 12, 2019

We can add a progress bar, internet speed to gdc.download(...) and other similar functions. Would like to work on this if I get a green signal. :)

@ayan-b
Copy link
Collaborator Author

ayan-b commented Mar 12, 2019

I have worked something similar to this here.

@yunhailuo
Copy link
Collaborator

Sure. That sounds fine. Two minor points:

  • Nice to have but we don't need to overkill this. This is not the core feature and should not have too much impact on performance.
  • Maybe make it stderr or something like that so it won't get into log or stdout if people want to collect logs whatever way.

@RJ722
Copy link

RJ722 commented Mar 29, 2019

Hi, I was just reading through the comments and thought that I could chime in. I read a pretty good discussion on Unix StackExchange regarding stream placement for progress bars and hope that it might help here.

@ayan-b
Copy link
Collaborator Author

ayan-b commented Mar 29, 2019

@RJ722 Thanks! I will keep in mind while implementing,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants