Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samtools #72

Open
niemasd opened this issue Mar 24, 2021 · 2 comments
Open

Update samtools #72

niemasd opened this issue Mar 24, 2021 · 2 comments

Comments

@niemasd
Copy link
Contributor

niemasd commented Mar 24, 2021

Updated comment:
A new version of samtools was just released, and I see that one of the features is that samtools depth was rewritten to be faster and more memory efficient. That's not a bottleneck of our pipeline, but it would still be good to update at some point (though not urgent):

https://github.com/samtools/samtools/releases/tag/1.13
Original comment:
The pipeline currently uses samtools 1.11, but samtools 1.12 was recently released:

https://github.com/samtools/samtools/releases/tag/1.12

Not urgent at all, but it would be good to update to samtools 1.12 at some point in the future

@AmandaBirmingham
Copy link
Collaborator

@niemasd Is there a particular reason it would be good to update? I am inclined to stick with the existing version until the regression tests are in place and accepted ...

@niemasd
Copy link
Contributor Author

niemasd commented Mar 24, 2021

No particular reason, and I agree that all tool versions should generally remain as-is until regression tests and other relevant tests are in place and accepted. Once everything is 100% functional and ready for production, then I think it may be worth exploring updating samtools for future versions of the pipeline

I just wanted to make this GitHub Issue while it was on my mind

@rob-knight rob-knight added the question Further information is requested label Mar 24, 2021
@AmandaBirmingham AmandaBirmingham removed the question Further information is requested label Mar 24, 2021
@AmandaBirmingham AmandaBirmingham changed the title Update samtools to 1.12 Update samtools Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants