-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed instability in upper atmosphere due to OGWD #111
Fixed instability in upper atmosphere due to OGWD #111
Conversation
…er for orographic gravity wave drag in UGWP -- Issue NOAA-GSL#95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdtoyNOAA The changes look good to me. Thanks!
… into ufs/dev_meso_fix_new_ksmax
…dule_sf_noahmplsm.F90
@mdtoyNOAA can you combine in code change from #115 to this PR? |
@jkbk2004 Sure I can do that. Just to make sure, would I pull Helin's 'hr3_land_upgrades' branch from the fork https://github.com/HelinWei-NOAA/ccpp-physics/tree/hr3_land_upgrades into my branch? Also, would I need to run RT's right away, or can I wait until Monday, 10/16 when it's my turn to merge the ufs-weather-model PR#1923? |
…ccpp-physics into ufs/dev_meso_fix_new_ksmax Incorporates PR#115
@mdtoyNOAA can you merge the hr3_land_upgrades branch again? @HelinWei-NOAA just pushed a final commit to that branch. |
@barlage Yes, I can do that, but first I'd like to confirm that I should not merge Anning's PR#109 before doing that. Or does it matter? |
…ccpp-physics into ufs/dev_meso_fix_new_ksmax
@barlage I merged the new hr3_land_upgrades branch. |
… into ufs/dev_meso_fix_new_ksmax
… into ufs/dev_meso_fix_new_ksmax
@grantfirl testing is complete on ufs-wm PR #1923, can you merge this PR for us, please? |
This PR fixes Issue #95, which involved a stability issue in the upper atmosphere due to the orographic gravity wave drag (OGWD) scheme and also limits the surface OGWD stress in regions of high surface winds (and/or low near-surface static stability) in which internal gravity waves should not develop.