Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gfdlmpv3 #2503

Open
wants to merge 41 commits into
base: develop
Choose a base branch
from

Conversation

dustinswales
Copy link
Collaborator

@dustinswales dustinswales commented Nov 18, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR contains host side changes to accommodate a new cloud microphysics parameterization in the physics.

For the physics refactoring, all of the configuration/namelist info is moved into a common module that is referenced by both MP versions and a shared fv_sat_adj.F90. There are default values for the scheme configurations defined within this module, and overwritten by the namelist, if provided. Both the v1 and v3 rely on some of the same parameters, but with different default values. This is handled by introducing a pre-processor directive into the new configuration module.

Commit Message:

* UFSWM - GFDL Microphysics Version 3

Priority:

  • Normal.

Git Tracking

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

  • PR Adds New Tests/Baselines (GFDLMPv3 Regression tests for HAFS_regional_atm and control_iovr4).
  • Logs on Hera: /scratch1/BMC/gmtb/Dustin.Swales/UFS/Ruyiu/ufs-weather-model/tests

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@dustinswales
Copy link
Collaborator Author

@RuiyuSun I added two new tests, one for each of the SDFs that have V3 enabled. This is overkill and we probably only need one for testing. If you agree, do you have a favorite of the two new RTs?

@RuiyuSun
Copy link
Contributor

@RuiyuSun I added two new tests, one for each of the SDFs that have V3 enabled. This is overkill and we probably only need one for testing. If you agree, do you have a favorite of the two new RTs?

@dustinswales I think the global RT is more convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants