-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eighth reconciliation PR from production/RRFS.v1 #2531
base: develop
Are you sure you want to change the base?
Conversation
@jkbk2004 @MatthewPyle-NOAA @haiqinli Do you know if the Hercules platform change from #2298 needs to go to the develop branch? |
Good afternoon, @grantfirl! I don't think I know the answer to that.. just wanted to check if you meant to tag @MatthewPyle-NOAA? |
Yes, indeed. Sorry @MatthewMasarik-NOAA ! |
All good @grantfirl! |
@grantfirl I think current hercules modulefiles on develop branch are ok. But we can do some pre-test to make sure. |
@grantfirl I'm not sure if I'm seeing what you mean in #2298 with regards to a Hercules change. |
It looks like there was a change in the rocoto module for use with hercules in tests/rt.sh in that PR. |
Current develop branch is most updated one on hercules:
|
Thanks @jkbk2004 . I'll leave this change out of this PR, then. |
Commit Queue Requirements:
Description:
This is work from @haiqinli and the changes are identical to #2298
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: