Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eighth reconciliation PR from production/RRFS.v1 #2531

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Dec 5, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step : no changes

Description:

This is work from @haiqinli and the changes are identical to #2298

Commit Message:

* UFSWM - minor bugfixes for smoke/dust for RRFS.v1
  * FV3 - minor bugfixes for smoke/dust for RRFS.v1
    * ccpp-physics - minor bugfixes for smoke/dust for RRFS.v1

Priority:

  • High: Needed for SRW App

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@grantfirl
Copy link
Collaborator Author

grantfirl commented Dec 5, 2024

@jkbk2004 @MatthewPyle-NOAA @haiqinli Do you know if the Hercules platform change from #2298 needs to go to the develop branch?

@MatthewMasarik-NOAA
Copy link
Collaborator

@jkbk2004 @MatthewMasarik-NOAA @haiqinli Do you know if the Hercules platform change from #2298 needs to go to the develop branch?

Good afternoon, @grantfirl! I don't think I know the answer to that.. just wanted to check if you meant to tag @MatthewPyle-NOAA?

@grantfirl
Copy link
Collaborator Author

@jkbk2004 @MatthewMasarik-NOAA @haiqinli Do you know if the Hercules platform change from #2298 needs to go to the develop branch?

Good afternoon, @grantfirl! I don't think I know the answer to that.. just wanted to check if you meant to tag @MatthewPyle-NOAA?

Yes, indeed. Sorry @MatthewMasarik-NOAA !

@MatthewMasarik-NOAA
Copy link
Collaborator

@jkbk2004 @MatthewMasarik-NOAA @haiqinli Do you know if the Hercules platform change from #2298 needs to go to the develop branch?

Good afternoon, @grantfirl! I don't think I know the answer to that.. just wanted to check if you meant to tag @MatthewPyle-NOAA?

Yes, indeed. Sorry @MatthewMasarik-NOAA !

All good @grantfirl!

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Dec 5, 2024

@grantfirl I think current hercules modulefiles on develop branch are ok. But we can do some pre-test to make sure.

@MatthewPyle-NOAA
Copy link
Collaborator

@grantfirl I'm not sure if I'm seeing what you mean in #2298 with regards to a Hercules change.

@grantfirl
Copy link
Collaborator Author

@grantfirl I'm not sure if I'm seeing what you mean in #2298 with regards to a Hercules change.

It looks like there was a change in the rocoto module for use with hercules in tests/rt.sh in that PR.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Dec 5, 2024

@grantfirl I'm not sure if I'm seeing what you mean in #2298 with regards to a Hercules change.

It looks like there was a change in the rocoto module for use with hercules in tests/rt.sh in that PR.

Current develop branch is most updated one on hercules:

(base) [jongkim@hercules-login-3 ~]$ module list

Currently Loaded Modules:
  1) contrib/0.1   2) rocoto/1.3.7

@grantfirl
Copy link
Collaborator Author

@grantfirl I'm not sure if I'm seeing what you mean in #2298 with regards to a Hercules change.

It looks like there was a change in the rocoto module for use with hercules in tests/rt.sh in that PR.

Current develop branch is most updated one on hercules:

(base) [jongkim@hercules-login-3 ~]$ module list

Currently Loaded Modules:
  1) contrib/0.1   2) rocoto/1.3.7

Thanks @jkbk2004 . I'll leave this change out of this PR, then.

@grantfirl grantfirl marked this pull request as ready for review December 23, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants