Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ugwpv1 timing / remove some extended WLCLK cases #2543

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dpsarmie
Copy link
Collaborator

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR will fix an issue with the export_ugwpv1() function in default_vars.sh. The sedi_semi check was inverted. This should now align with the GW spec.
Changing this timestep also required some changes in the K_SPILT and N_SPLIT variables for select regression tests.
These fixes also reduced the runtime of some regression tests. Those tests had the custom changes to WLCLK removed since they are running under the 30 min limit.
A new namelist variable was also added (XR_CNVCLD) to more closely align with the GW namelist needs.

Commit Message:

* UFSWM - Fix sedi_semi logic issue in export_ugwpv1() and change affected RTs for more stable and quicker runtimes.

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@@ -1187,7 +1188,7 @@ export_ugwpv1() {
esac

if [[ ${DO_GSL_DRAG_SS} = .true. ]]; then export CDMBGWD=${CDMBGWD_GSL}; fi
if [[ ${SEDI_SEMI} = .true. ]]; then export DT_ATMOS=$((DT_ATMOS/2)); fi
if [[ ${SEDI_SEMI} = .false. ]]; then export DT_ATMOS=$((DT_ATMOS/2)); fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DT_ATMOS stays the same and DT_INNER changes:
if [[ ${SEDI_SEMI} = .false. ]]; then export DT_INNER=$((DT_ATMOS/2)); fi

dt_inner in ccpp is for subcycling in the Thompson MP scheme

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think SEDI_SEMI=.true. for all RTs that get here so there's no need to re-test anything you've done

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, got it fixed and it doesn't affect any of the RTs. Leaving the check in even if it doesn't get triggered for GW fidelity and reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEDI_SEMI incorrectly halves DT_ATMOS in tests/default_vars.sh
2 participants