Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render fix #671

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Render fix #671

merged 3 commits into from
Dec 11, 2024

Conversation

maddenp-noaa
Copy link
Collaborator

@maddenp-noaa maddenp-noaa commented Dec 11, 2024 •
edited
Loading

Synopsis

Fixes a bug whereby a value like &XMLENTITY; that cannot be parsed as YAML on its own would lead to a dereferencing failure. See the new unit test for an example.

Type

  • Bug fix (corrects a known issue)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Dec 11, 2024
maddenp-noaa
maddenp-noaa commented Dec 11, 2024
View reviewed changes
src/uwtools/config/formats/base.py Show resolved Hide resolved
src/uwtools/config/jinja2.py Show resolved Hide resolved
src/uwtools/config/jinja2.py Show resolved Hide resolved
src/uwtools/tests/config/test_jinja2.py Show resolved Hide resolved
@maddenp-noaa maddenp-noaa marked this pull request as ready for review December 11, 2024 22:03
christinaholtNOAA
christinaholtNOAA approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the quick fix!!

@maddenp-noaa maddenp-noaa merged commit 0a9813d into ufs-community:main Dec 11, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the render-fix branch December 11, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@Byrnetp Byrnetp Awaiting requested review from Byrnetp Byrnetp is a code owner

@NaureenBharwaniNOAA NaureenBharwaniNOAA Awaiting requested review from NaureenBharwaniNOAA NaureenBharwaniNOAA is a code owner

@elcarpenterNOAA elcarpenterNOAA Awaiting requested review from elcarpenterNOAA elcarpenterNOAA is a code owner

Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maddenp-noaa @christinaholtNOAA