-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sim search refactoring #466
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11487172 | Triggered | Company Email Password | 1a484f5 | docker/.env.example | View secret |
11487172 | Triggered | Company Email Password | d23c72c | docker/.env.example | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
for more information, see https://pre-commit.ci
45d4975
to
19069f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
puh. mit 3 vector dbs müssen einige neue configs in .env.example(s) eingeführt werden.
das depends_on in compose.yml wird ein echtes problem. bin gespannt ob das gelöst werden kann, ob man die irgendwie dynamisch machen kann
This PR refactors the sim search service by splitting the functionality into multiple services:
Old: simsearch service is basically hard-wired to use weaviate
new: simsearch service provides generic methods to search for similar images, sentences, documents etc. it internally uses a vectorIndexService (via interface/abstract class)
to retain the old behavior, there is an implementation of the vectorindexService using weaviate. However, I've also included some partial implementations to try out typesense and qdrant instead.