Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configurations #467

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Improve configurations #467

merged 5 commits into from
Nov 14, 2024

Conversation

bigabig
Copy link
Member

@bigabig bigabig commented Nov 13, 2024

i added docker compose override files to not export so many ports in production environment

Copy link

gitguardian bot commented Nov 13, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11487170 Triggered Generic Password 4edbbee docker/docker-compose.yml View secret
11487170 Triggered Generic Password 4edbbee docker/docker-compose.yml View secret
11487170 Triggered Generic Password 4edbbee docker/docker-compose.yml View secret
11487171 Triggered Generic Password 4edbbee docker/.env.example View secret
11487170 Triggered Generic Password 4edbbee docker/docker-compose.yml View secret
11487170 Triggered Generic Password 4edbbee docker/docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@bigabig bigabig merged commit 61b88d2 into mwp_v1 Nov 14, 2024
4 checks passed
@bigabig bigabig deleted the improve-configurations branch November 14, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant