Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert neoclassics module to python #3360

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

timothy-nunn
Copy link
Contributor

Converts all of the methods in neoclassics_module.f90 to Python

@timothy-nunn timothy-nunn linked an issue Oct 24, 2024 that may be closed by this pull request
@timothy-nunn timothy-nunn force-pushed the 3183-convert-neoclassics_modulef90-to-python branch 2 times, most recently from 236de56 to c98589b Compare October 24, 2024 15:20
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 98.40000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.61%. Comparing base (42780a9) to head (3f7962e).

Files with missing lines Patch % Lines
process/main.py 50.00% 1 Missing ⚠️
process/stellarator.py 99.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3360      +/-   ##
==========================================
+ Coverage   27.11%   27.61%   +0.49%     
==========================================
  Files          77       77              
  Lines       17816    17939     +123     
==========================================
+ Hits         4831     4953     +122     
- Misses      12985    12986       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timothy-nunn timothy-nunn force-pushed the 3183-convert-neoclassics_modulef90-to-python branch from c98589b to e95cf99 Compare October 24, 2024 15:35
@jonmaddock jonmaddock self-requested a review October 31, 2024 13:15
@timothy-nunn timothy-nunn force-pushed the 3183-convert-neoclassics_modulef90-to-python branch 3 times, most recently from 448934d to 4874e7e Compare November 8, 2024 11:22
* Remove unused neoclassic routine
* Add tests for neoclassics module
* Convert init_neoclassics to Python
* Convert init_profile_values_from_PROCESS to Python
* Convert neoclassics roots and weights functions to Python
* Convert neoclassics_calc_KT to Python
* Convert neoclassics_calc_nu to Python
* Convert neoclassics_calc_nu_star to Python
* Convert neoclassics_calc_nu_star_fromT to Python
* Convert neoclassics_calc_vd to Python
* Convert neoclassics_calc_D11_plateau to Python
* Convert neoclassics_calc_d11_mono to Python
* Convert neoclassics_calc_D11(1/2/3) to Python
* Convert neoclassics_calc_Gamma_flux to Python
* Convert neoclassics_calc_q_flux to Python
@timothy-nunn timothy-nunn force-pushed the 3183-convert-neoclassics_modulef90-to-python branch from 4874e7e to 3f7962e Compare November 8, 2024 11:57
@timothy-nunn timothy-nunn merged commit 01865a0 into main Nov 13, 2024
18 checks passed
@timothy-nunn timothy-nunn deleted the 3183-convert-neoclassics_modulef90-to-python branch November 13, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert neoclassics_module.f90 to Python
3 participants