Convert blanket libraryf90 to python #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3384 +/- ##
==========================================
+ Coverage 27.11% 27.78% +0.66%
==========================================
Files 77 77
Lines 17816 18097 +281
==========================================
+ Hits 4831 5028 +197
- Misses 12985 13069 +84 ☔ View full report in Codecov by Sentry. |
timothy-nunn
force-pushed
the
3371-convert-blanket_libraryf90-to-python
branch
from
9c1511f
to
32ad020
Compare
* Add module description and comments * Convert component_volumes to Python * Convert component_half_height to Python * Convert dshaped_component to Python * Convert elliptical_component to Python * Convert apply_coverage_factors to Python * Convert external_cryo_geometry to Python * Convert component_masses to Python * Convert blanket_mod_pol_height to Python * Convert flow_velocity to Python * Convert liquid_breeder_properties to Python * Rewrite blanket library fortran to support conversion * Convert pressure_drop to Python * Convert hydraulic_diameter to Python * Convert elbow_coeff to Python * Convert liquid_breeder_pressure_drop_mhd to Python
timothy-nunn
force-pushed
the
3371-convert-blanket_libraryf90-to-python
branch
from
32ad020
to
4a3386d
Compare
jonmaddock
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts remaining physics and engineering routines in the blanket library to Python