Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L-H threshold comparison plot and improve bootstrap comparison la… #3405

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

chris-ashe
Copy link
Collaborator

@chris-ashe chris-ashe commented Nov 20, 2024

This pull request includes several changes to the process/io/plot_proc.py and process/io/plot_radial_build.py files to enhance plotting functionalities and improve the readability of plotted data.

Enhancements to plotting functionalities:

  • New Plot Function: Added a new function plot_h_threshold_comparison to create a scatter box plot of L-H threshold power comparisons. This function includes data extraction, violin plot, box plot, scatter plot, and statistical text display. (process/io/plot_proc.py)
  • Integration of New Plot: Integrated the new plot_h_threshold_comparison function into the main_plot function to display the new plot in the subplot layout. (process/io/plot_proc.py)

Improvements to existing plots:

  • Text Position Adjustment: Adjusted the position of text displaying average, standard deviation, and median in the plot_bootstrap_comparison function for better visibility. (process/io/plot_proc.py)
  • Background Color: Added a light grey background color to the axis in the plot_bootstrap_comparison and plot_h_threshold_comparison functions to improve plot readability. (process/io/plot_proc.py)

Code readability:

  • Label Formatting: Improved label formatting in the main function of plot_radial_build.py to display radial build measurements with three decimal places. (process/io/plot_radial_build.py)…bels. Make plot_radial_build only shows values to 3dp

Description

image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

…bels. Make plot_radial_build only shows values to 3dp
@chris-ashe chris-ashe added the Documentation Improvements or additions to documentation label Nov 20, 2024
@chris-ashe chris-ashe self-assigned this Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 1.58730% with 62 lines in your changes missing coverage. Please review.

Project coverage is 28.27%. Comparing base (181627a) to head (088ae55).

Files with missing lines Patch % Lines
process/io/plot_proc.py 1.58% 62 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3405      +/-   ##
==========================================
- Coverage   28.36%   28.27%   -0.10%     
==========================================
  Files          77       77              
  Lines       18365    18428      +63     
==========================================
+ Hits         5209     5210       +1     
- Misses      13156    13218      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@chris-ashe chris-ashe marked this pull request as ready for review November 21, 2024 08:59
@timothy-nunn timothy-nunn merged commit 73d1488 into main Nov 21, 2024
18 checks passed
@timothy-nunn timothy-nunn deleted the add_lh_threshold_plot_to_plot_proc branch November 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants