Fix XSX and update XDC source for DEFUSE #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshod5
requested changes
Aug 13, 2024
There was a problem hiding this comment.
test_xsx_camera_params fails, believe it is because of line 304 or 310 (need to look into the logs). Changing the name maybe
There was a problem hiding this comment.
Yea. Will fix this.
There was a problem hiding this comment.
more for curiosity, will we be re-introducing the tensorising bits later on then?
There was a problem hiding this comment.
Yes. But we've currently done this quite crudely. Nathan and I have some notes from talking to charlie vincent about xdc. We can do this a bit better than the current implementation. But it should not be done here. Here I just want to get the one signal that is important for DEFUSE.
|
@jameshod5 I think this is ready to be re-reviewed please! |
|
Looks okay to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the soft x-ray source code to fix a bug with adding camera params. This also removes most of the XDC processing for now. We only capture IPref as this is required by DEFUSE.