Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CSD3 #3

Merged
merged 10 commits into from
Aug 19, 2024
Merged

Add support for CSD3 #3

merged 10 commits into from
Aug 19, 2024

Conversation

samueljackson92
Copy link
Collaborator

@samueljackson92 samueljackson92 commented Aug 15, 2024

This removes the segfault handling code and adds jobscripts for CSD3.

To review:

  • Follow the setup & running instructions in the README
  • Code review.

Note use:

python -m pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple uda

to upgrade uda

@samueljackson92 samueljackson92 added the enhancement New feature or request label Aug 15, 2024
Copy link
Collaborator

@jameshod5 jameshod5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python -m pip install --U pip - This doesn't work for me, have to use --upgrade instead. (or change to -U instead)

other two comments are more suggestions, but the above needs to be fixed

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@samueljackson92
Copy link
Collaborator Author

I had added your suggestions to the README.

@jameshod5
Copy link
Collaborator

python -m pip install --U pip - This doesn't work for me, have to use --upgrade instead. (or change to -U instead)

other two comments are more suggestions, but the above needs to be fixed

This still needs to change to python -m pip install --upgrade pip or python -m pip install -U pip

@samueljackson92
Copy link
Collaborator Author

Sorry missed that one!

@jameshod5 jameshod5 merged commit 8d514d4 into main Aug 19, 2024
2 checks passed
@jameshod5
Copy link
Collaborator

Looks good, merged

@samueljackson92
Copy link
Collaborator Author

samueljackson92 commented Aug 19, 2024 via email

@samueljackson92 samueljackson92 deleted the support-csd3 branch October 15, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants