Search improvements: release to user-facing interface #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamLamb
reviewed
Aug 1, 2023
marcelkornblum
changed the title
CamLamb
reviewed
Aug 15, 2023
| if not model_field_name: | ||
| model_field_name = field.field_name | ||
| if field not in parent_fields and model_field_name not in model_fields: | ||
| message = "indexed field '{name}' is defined in {model} and {parent}" |
There was a problem hiding this comment.
Should the definition of this string be closer to the errors.append?
CamLamb
approved these changes
Aug 15, 2023
SamDudley
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge this when you want to deploy the search improvements to prod
Makes the search improvements underpinning the explore page join up with and connect in to the main user facing search
also updates tracking version number for easier analytics segregation
NB. May need to re-index and/or run page save operation for each page in order to re-populate index