Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBTP-457 Use dbt-copilot-python to set ALLOWED_HOSTS & DATABASES in DBT PaaS #461

Merged
merged 7 commits into from
Sep 22, 2023
Merged

DBTP-457 Use dbt-copilot-python to set ALLOWED_HOSTS & DATABASES in DBT PaaS #461

merged 7 commits into from
Sep 22, 2023

Conversation

WillGibson
Copy link
Contributor

@WillGibson WillGibson commented Sep 21, 2023 •
edited
Loading

What it says in the title, plus it should remain compatible with GOV.UK PaaS.

@WillGibson WillGibson changed the title To be confirmed DBTP-457 Use dbt-copilot-python to set ALLOWED_HOSTS & DATABASES in DBT PaaS Sep 22, 2023
WillGibson
WillGibson commented Sep 22, 2023
View reviewed changes
package.json Show resolved Hide resolved
src/config/settings/base.py Show resolved Hide resolved
@WillGibson WillGibson marked this pull request as ready for review September 22, 2023 10:26
CamLamb
CamLamb approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@CamLamb CamLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Note: that this will deploy to staging on merge to main

@WillGibson WillGibson merged commit aa2b54f into main Sep 22, 2023
1 check passed
@WillGibson WillGibson deleted the DBTP-457-make-govuk-and-dbt-paas-compatible-e2e branch September 22, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CamLamb CamLamb CamLamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillGibson @CamLamb