Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWPF-783 Bug fix - None was displayed if location in building field was left blank #465

Conversation

nicopicchio
Copy link
Contributor

No description provided.

@nicopicchio nicopicchio requested a review from CamLamb September 22, 2023 11:05
Copy link
Contributor

@CamLamb CamLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a comment with an alternative approach.
I'm happy for this to be merged as is, or with the change, up to you 😄

src/peoplefinder/models.py Show resolved Hide resolved
@nicopicchio nicopicchio changed the title DWPF-783 Fixes bug where None was displayed if location in building field was not filled in DWPF-783 Fixes bug where None was displayed if location in building field was left blank Sep 22, 2023
@nicopicchio nicopicchio changed the title DWPF-783 Fixes bug where None was displayed if location in building field was left blank DWPF-783 Bug fix - None was displayed if location in building field was left blank Sep 22, 2023
@nicopicchio nicopicchio merged commit 0a4998d into main Sep 22, 2023
1 check passed
@nicopicchio nicopicchio deleted the DWPF-783-office-location-remains-blank-when-no-location-specified branch September 22, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants