lzma: do not panic upon invalid inputs in syncDict.writeRep #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found by go-fuzz.
|
Hi, many thanks for reporting this. The panic indicates a bug in the encoder that must not happen at all. Therefore it doesn't make sense to return an error here. Could you please provide me with the go-fuzz routine and the crasher byte sequence to find the cause for the bug? After that it needs to be checked whether the bug is still present in the dev tree and fix the bug there. I create issue #3 to fix the bug. Please use it for any follow-on discussion. Again many thanks, Uli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by go-fuzz.
I would replace all the panics in lzma package as well, but I do not know the code at all and they might be actual invariants. You know better than I do.