0.31 fix memory leak - thanks zxsleebu

ultrafunkamsterdam · Jul 6, 2024 · 688c948 · 688c948
1 parent 805bb0e
commit 688c948
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/nodriver/core/_contradict.py b/nodriver/core/_contradict.py
@@ -139,7 +139,7 @@ def _camel_to_snake(s):
     :param str s: string to be converted
     :return: (str) snake_case version of s
     """
-    s = s.replace("-", "").replace(".", "")
+    s = s.replace("-", "").replace(".", "").replace(" ", "_")
 
     return __RE_CAMEL_TO_SNAKE__.sub(r"_\1", s).lower()
 

diff --git a/nodriver/core/connection.py b/nodriver/core/connection.py
@@ -551,8 +551,12 @@ async def listener_loop(self):
                 # response to our command
                 if message["id"] in self.connection.mapper:
                     # get the corresponding Transaction
-                    tx = self.connection.mapper[message["id"]]
+
+                    # pop to prevent memory leaks
+                    # thanks to zxsleebu
+                    tx = self.connection.mapper.pop(message["id"])
                     logger.debug("got answer for %s", tx)
+
                     # complete the transaction, which is a Future object
                     # and thus will return to anyone awaiting it.
                     tx(**message)