Fix missing site_url bug

[glenn-jocher]

No description provided.

[sourcery-ai]

PR Type: Bug fix

PR Summary: The pull request addresses an issue where the 'site_url' configuration was not being checked before use, which could lead to incorrect behavior or errors. The changes include a warning message when 'site_url' is not set and a fallback to an empty string to prevent concatenation issues.

Decision: Comment

📝 Type: 'Bug fix' - not supported yet.

• Sourcery currently only approves 'Typo fix' PRs.

✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.

No details provided.

📝 Complexity: the changes are too large or complex for Sourcery to approve.

• Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

• Consider using a logging mechanism instead of direct print statements for warnings to allow better control in different environments.
• Review the URL concatenation logic to ensure that it correctly handles edge cases, such as missing or malformed 'site_url' values.
• Implement a more explicit conditional expression for handling the absence of 'site_url' to provide clearer error handling or fallback strategies.
• Ensure that there is clear handling or logging when features are disabled through configuration flags, to avoid confusion about the plugin's behavior.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

• X
• Mastodon
• LinkedIn
• Facebook

---

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.