-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added warning message when --single-cls
is used incorrectly by [#13028](https://github.com/ultralytics/yolov5/issues/13028)
#13032
Conversation
All Contributors have signed the CLA. ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @Le0v1n, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with
ultralytics/yolov5
master
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge master
locally. - ✅ Verify all YOLOv5 Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
I have read the CLA Document and I sign the CLA |
@glenn-jocher My code passed the initial test, but after Ultralytics made a commit, the following issue occurred during retesting:
It seems that the test failure was due to a network issue rather than the code I modified. How can I request a retest? |
Hi there! It looks like the issue you encountered is indeed related to a network or cache service error during the GitHub Actions run, and not directly linked to your code changes. To request a retest, you can simply push an empty commit to your branch or close and reopen the pull request to trigger the GitHub Actions again. Here’s how you can push an empty commit: git commit --allow-empty -m "Trigger retest"
git push This should start the CI tests anew. Let us know if you need any more help! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-CI for PR
@glenn-jocher Thank you very much for your reply, I have pushed again. 🥰 |
You're welcome! If you need further assistance, feel free to ask. Happy coding! 😊 |
Hello, I am very happy to be able to submit code to Ultralytics. However, this simple piece of code has been submitted for a long time, and I receive email reminders from UltralyticsAssistant every week. After I click the link, it also reminds me "This branch has no conflicts with the base branch". All checks have passed, but it seems that the code has not been merged into the master branch. What action do I need to take? (please forgive me for being almost a novice in this area) |
@Le0v1n hello! Thank you for your contribution and for your patience. We truly appreciate your effort to improve YOLOv5! 😊 It sounds like your pull request is in good shape, especially since all checks have passed and there are no conflicts. Sometimes, the merging process can take a bit of time due to various factors, such as ongoing reviews or other priorities. Here are a few steps you can take to ensure everything is in order:
If you have any further questions or need additional assistance, feel free to ask. We're here to help! Thank you again for your valuable contribution to the YOLOv5 project. |
@glenn-jocher Thank you for your reply, I will just continue to wait. 😊 |
Hi @Le0v1n, Thank you for your patience and understanding! 😊 We appreciate your enthusiasm and contribution to the YOLOv5 project. If you have any further questions or need additional assistance while waiting, feel free to reach out here. We're always here to help and ensure that your experience with YOLOv5 is smooth and productive. Thank you again for your valuable contribution and for being a part of the Ultralytics community! |
Alright, I think I understand what you mean now, so I'll close this PR. |
Hi there, Thank you for your understanding and for taking the time to address the issue. If you encounter any further problems or have additional questions, please feel free to open a new issue or PR. We're here to help and ensure you have a smooth experience with YOLOv5. If you haven't already, please make sure to verify that any issues persist with the latest versions of Should you need to provide more details or a minimum reproducible code example in the future, you can refer to our guide here: Minimum Reproducible Example. This helps us investigate and address any issues more effectively. Thank you again for your contribution and for being a part of the Ultralytics community! 😊 |
In issue #13028, I raised a question about
--single-cls
and provided a code suggestion, therefore I am applying for a PR. I only modified the code intrain.py
, as shown below:Here, by setting a warning, we prevent users from mistakenly using the
--single-cls
parameter during training. This is because when the number of classes in the dataset configuration file is not 1,--single-cls
will force the dataset into the form{0: "item"}
.I have tested the code locally with the following shell command:
Since the MS COCO dataset has 80 classes, the program normally issued a warning as follows:
I'm very happy to submit code to Ultralytics! 🥰
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhanced dataset validation and warning for
--single-cls
mode in training.📊 Key Changes
--single-cls
is enabled but the dataset indicates multiple classes.--single-cls
is used incorrectly.🎯 Purpose & Impact
--single-cls
flag. 🎯