Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ios build #416

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix ios build #416

merged 1 commit into from
Sep 6, 2024

Conversation

trittsv
Copy link
Contributor

@trittsv trittsv commented Sep 2, 2024

This PR fixes iOS builds.

On iOS it takes special care to build a executable, app bundle identifier are needed etc.

In a typical iOS build you only want to have the kvazaar lib to link with your app.

Because of that the option -DBUILD_KVAZAAR_BINARY=OFF is introduced to be able to build for iOS.

The build error looked like this:

cmake -G Xcode \
  -DBUILD_SHARED_LIBS=OFF \
  -DCMAKE_TOOLCHAIN_FILE=./ios.toolchain.cmake \
  -DPLATFORM=OS64 \
  -DBUILD_TESTS=OFF \
  -DCMAKE_BUILD_TYPE=Release \
  .. \
  && \
  xcodebuild -project kvazaar.xcodeproj \
                        -scheme install \
                        -configuration Release \
                        -quiet \
                        -allowProvisioningUpdates \
                        -destination generic/platform=iOS \
                        -derivedDataPath ./build \
                        build
. . .
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/sventrittler/workspace/thridparty/kvazaar/x
note: Run script build phase 'Generate CMakeFiles/ZERO_CHECK' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'ZERO_CHECK' from project 'kvazaar')
/Users/sventrittler/workspace/thridparty/kvazaar/x/kvazaar.xcodeproj: error: Bundle identifier is missing. kvazaar-bin doesn't have a bundle identifier. Add a value for PRODUCT_BUNDLE_IDENTIFIER in the build settings editor. (in target 'kvazaar-bin' from project 'kvazaar')
** BUILD FAILED **

@fador fador merged commit 7e4447f into ultravideo:master Sep 6, 2024
@fador
Copy link
Member

fador commented Sep 6, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants