Make visible titles from the control bar on hover #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a bit broken when the button has a border-radius. Should we style the right border of the title element to make it like an arrow or something ? |
|
For the border radius, we can fake the junction with a few less px of the negative margin, for the arrow though it will get harder because we are already dealing with an extra element from Anyway, that was more a proof of concept to verify it it's useful or not to go down that way. Also, there will probably be some issues with translations lengths for some verbose languages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at making labels of buttons from the control bar more explicit when hovering (it reuses the
titleattribute of these links).