Added fix for general BaseDataVariableType handling. #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdornaus
force-pushed
the
fix_general_BaseDataVariableTypes
branch
from
1edd757
to
e8d35a2
Compare
ccvca
reviewed
Sep 1, 2023
ccvca
reviewed
Sep 5, 2023
ccvca
reviewed
Sep 5, 2023
ccvca
reviewed
Sep 5, 2023
mdornaus
force-pushed
the
fix_general_BaseDataVariableTypes
branch
from
aeeaa89
to
e356be0
Compare
GoetzGoerisch
force-pushed
the
fix_general_BaseDataVariableTypes
branch
from
e356be0
to
9a3e29e
Compare
ccvca
requested changes
Oct 2, 2023
ccvca
approved these changes
Nov 13, 2023
…ded check if NodeId is of BaseDataVariableType.
…riableType in ModelToJsonConverter.
GoetzGoerisch
force-pushed
the
fix_general_BaseDataVariableTypes
branch
from
1d4342a
to
c8574df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed identification of BaseDataVariableTypes and applied a general handling of these types in the ModelToJsonConverter (Removed usage of explizit NodeIds).