Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Sets correct LIBCCP_VERSION #661

Merged
merged 2 commits into from
Apr 25, 2024
Merged

fix(build): Sets correct LIBCCP_VERSION #661

merged 2 commits into from
Apr 25, 2024

Conversation

GoetzGoerisch
Copy link
Member

No description provided.

@GoetzGoerisch GoetzGoerisch linked an issue Dec 6, 2023 that may be closed by this pull request
@GoetzGoerisch
Copy link
Member Author

@marcfir @ccvca above fixes #598 but sets libstdc++6 to 13.1.0 as this is the latest on action-runners but not available on a standard ubuntu-22.04 installation.

https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#language-and-runtime

How to set a specific installed version in the CI?

@marcfir
Copy link
Member

marcfir commented Dec 7, 2023

Yes this is due to the assumption that the used versions in the runner are available in the official apt repository.

One possibility is a configuration file somewhere. But this means manual adaption.

@ccvca
Copy link
Member

ccvca commented Dec 7, 2023

Can this build be done in a Docker-Container?

@marcfir
Copy link
Member

marcfir commented Dec 7, 2023

This should be possible. Good idea.

@GoetzGoerisch
Copy link
Member Author

@marcfir @ccvca should we merge this fix with the downgrade in the CI or wait till this happens: actions/runner-images#9679

@GoetzGoerisch GoetzGoerisch marked this pull request as ready for review April 24, 2024 11:13
Copy link
Member

@marcfir marcfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GoetzGoerisch GoetzGoerisch added this pull request to the merge queue Apr 25, 2024
Merged via the queue into development with commit 8160329 Apr 25, 2024
47 checks passed
@GoetzGoerisch GoetzGoerisch deleted the fix-598 branch August 26, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.deb Package invalid on Debian
3 participants