-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing the Delay Queue #74
base: master
Are you sure you want to change the base?
Conversation
transactions in the memory controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The delayedInfo
class definition seems to be missing. Can you make sure you included all the changes made in order to build the code successfully? Thanks!
Changes to be committed: modified: MultiChannelMemorySystem.h
Hi Shawn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rommelsv ,
Thanks for the patch.
I was able to build after your commit. But I think there's still some problems that I can see now:
-
There's no default parameter provided for DQ_DEPTH, which I assume will be in sys.ini, right?
-
I tried to add a DQ_DEPTH=20 to sys.ini and ran a few experiments, but it doesn't look like the program took it as an input. I think it should be included in configmap of IniReader.cpp. (I saw you had it but somehow commented it out?)
HI Shavvn, |
Implementation of the Delay Queue, an extra delay for all memory transactions in the memory controller.