Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: qa running with docker network #2105

Merged
merged 4 commits into from
Jun 26, 2023
Merged

tests: qa running with docker network #2105

merged 4 commits into from
Jun 26, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Jun 22, 2023

Description

The QA Test now spin the multinode without price-feeder, gaia and relayer in docker container

# to run the qa tests
make test-qa

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #2105 (5d2dca3) into main (7f05ad4) will decrease coverage by 0.39%.
The diff coverage is 77.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2105      +/-   ##
==========================================
- Coverage   75.38%   75.00%   -0.39%     
==========================================
  Files         100      127      +27     
  Lines        8025     9776    +1751     
==========================================
+ Hits         6050     7332    +1282     
- Misses       1589     1957     +368     
- Partials      386      487     +101     
Impacted Files Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/client/tests/suite.go 100.00% <ø> (ø)
x/leverage/client/tests/tests.go 100.00% <ø> (ø)
x/leverage/keeper/borrows.go 77.58% <ø> (-0.99%) ⬇️
x/leverage/keeper/collateral.go 72.72% <ø> (-0.16%) ⬇️
x/leverage/keeper/errors.go 100.00% <ø> (ø)
x/leverage/keeper/exchange_rate.go 72.72% <ø> (ø)
x/leverage/keeper/genesis.go 87.23% <ø> (ø)
... and 63 more

... and 25 files with indirect coverage changes

@gsk967 gsk967 marked this pull request as ready for review June 22, 2023 17:58
@gsk967 gsk967 requested a review from a team as a code owner June 22, 2023 17:59
@gsk967 gsk967 enabled auto-merge June 23, 2023 06:53
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see if we can avoid setting env var for executing configuration

tests/e2e/setup/setup.go Show resolved Hide resolved
tests/e2e/setup/chain.go Outdated Show resolved Hide resolved
sdkclient/tx/client.go Show resolved Hide resolved
@gsk967 gsk967 added this pull request to the merge queue Jun 26, 2023
Merged via the queue into main with commit 8505c7f Jun 26, 2023
@gsk967 gsk967 deleted the sai/qa_dockernet branch June 26, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants