-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement fast-liquidation #2106
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2106 +/- ##
==========================================
- Coverage 75.38% 75.00% -0.39%
==========================================
Files 100 127 +27
Lines 8025 9776 +1751
==========================================
+ Hits 6050 7332 +1282
- Misses 1589 1957 +368
- Partials 386 487 +101
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that there are few risks with the approach (liquidator going into danger zone, liquidator getting a debt to pay, which is not paid automatically), let's make sure we:
- document this in the README (or other file, and link it to README).
- update the proto comments
- update CLI (just saying that liquidator will take borrowers debt, which later the liquidator will need to pay).
- also let's rename Fast Liquidation to Leverage Liquidation (good name suggestion by Adam)
I will add few follow up tasks to linear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Left few docs suggestions.
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
All suggestions committed - moving to merge |
Follows up on the proto PR. Will include feature and tests.