feat: add borrow factor #2114
Merged
feat: add borrow factor #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2114 +/- ##
==========================================
- Coverage 75.38% 74.64% -0.75%
==========================================
Files 100 127 +27
Lines 8025 9881 +1856
==========================================
+ Hits 6050 7376 +1326
- Misses 1589 2003 +414
- Partials 386 502 +116
|
toteki
commented
Jun 26, 2023
robert-zaremba
requested changes
Jun 27, 2023
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
robert-zaremba
added a commit
that referenced
this pull request
Jun 28, 2023
* cl++ * cl++ * rephrase test - sign changes based on cpu architecture so strict equal avoided * implement borrow factor restriction * fix new uToken calc * Update x/leverage/keeper/oracle.go * Update x/leverage/types/token.go * revert * revert * implement borrow factor in userMaxBorrow * implement userMaxBorrow + cause failing wasm test * lint * add denom to test suite registry * max withdaw test * withdraw and max withdraw tests * borrow and maxborrow tests * renaming suggestion * halfDec * rename * README * Update x/leverage/README.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * readme suggestions --------- Co-authored-by: Robert Zaremba <robert@zaremba.ch>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
* perf: remove unnecessary null byte * Apply suggestions from code review Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> * feat: add borrow factor (#2114) * cl++ * cl++ * rephrase test - sign changes based on cpu architecture so strict equal avoided * implement borrow factor restriction * fix new uToken calc * Update x/leverage/keeper/oracle.go * Update x/leverage/types/token.go * revert * revert * implement borrow factor in userMaxBorrow * implement userMaxBorrow + cause failing wasm test * lint * add denom to test suite registry * max withdaw test * withdraw and max withdraw tests * borrow and maxborrow tests * renaming suggestion * halfDec * rename * README * Update x/leverage/README.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * readme suggestions --------- Co-authored-by: Robert Zaremba <robert@zaremba.ch> * tests: remove gb from e2e tests (#2119) * tests: remove gb from e2e tests * go.mod tidy --------- Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR will hold borrow factor logic and altered (and new) test cases