-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: more incentive test flows #2124
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2124 +/- ##
==========================================
- Coverage 75.38% 74.48% -0.91%
==========================================
Files 100 127 +27
Lines 8025 9968 +1943
==========================================
+ Hits 6050 7425 +1375
- Misses 1589 2039 +450
- Partials 386 504 +118
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flows 3,4 & 5 are not implemented: https://linear.app/umee/issue/UMEE-678/more-test-flows-for-xincentive
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- program can have leftovers if there are people who are not bonded by the end of the program. As discussed - recovering the leftovers is not a blocker for the release, but must be documented and scheduled for the next release
- documentation: we need to clearly document what is happening when there is a gap in bonding, and when leftovers are produced
- New Test case is needed:
- alice and bob joins before the program. Alice bonds 3x what bob bonds
- alice exits at 20% of the time
- bob exits at 30% of the time
- bob rejoins at 50% of the time and stays till the end.
- expected rewards (
T = total rewards of the program
):alice = T*20%*3/4
bob = T - alice_rewards
- so all rewards are distributed, there are no leftovers
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Added the final test scenario There is also documentation (in the EndBlocker functions) about what happens in the zero-bonded edge case, which I have highlighted in the diff by adding more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few final comments to improve the test.
Overall good job. Thanks @toteki and @EbrahimUmee for getting this test suite to the finish line.
let's make sure to fill checkboxes before merging: #2124 (review) |
Let's move this PR to the finish line. There are few open comments which have to be solved. |
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Resolved all issues, but need to redo PR due to unsigned commits |
replaced by: #2124 |
Additional reward calculation and timing scenarios as requested