Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: emergency group ugov proto #2129

Merged
merged 11 commits into from
Jul 10, 2023
Merged

feat: emergency group ugov proto #2129

merged 11 commits into from
Jul 10, 2023

Conversation

robert-zaremba
Copy link
Member

  • proto messages
  • server interface

@robert-zaremba robert-zaremba added the skip-e2e-test Skip the e2e tests label Jul 6, 2023
@robert-zaremba robert-zaremba marked this pull request as ready for review July 6, 2023 22:24
@robert-zaremba robert-zaremba requested a review from a team as a code owner July 6, 2023 22:24
toteki
toteki reviewed Jul 7, 2023
View reviewed changes
proto/umee/ugov/v1/tx.proto Outdated Show resolved Hide resolved
toteki
toteki reviewed Jul 7, 2023
View reviewed changes
tests/accs/accounts.go Outdated Show resolved Hide resolved
toteki
toteki reviewed Jul 7, 2023
View reviewed changes
tests/accs/accounts.go Outdated Show resolved Hide resolved
toteki
toteki approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check proto naming and comments

Pre-approving

gsk967
gsk967 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

robert-zaremba and others added 3 commits July 10, 2023 11:40
@robert-zaremba @toteki
Apply suggestions from code review
76d1859 
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
@robert-zaremba
Merge branch 'main' into robert/eg-proto
d494a67
@robert-zaremba
review
1f8c7e4
@robert-zaremba robert-zaremba added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit 6957f5a Jul 10, 2023
21 checks passed
@robert-zaremba robert-zaremba deleted the robert/eg-proto branch July 10, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsk967 gsk967 gsk967 approved these changes

@toteki toteki toteki approved these changes

Assignees
No one assigned
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-zaremba @gsk967 @toteki