Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: leverage e2e #2233

Merged
merged 40 commits into from
Sep 12, 2023
Merged

test: leverage e2e #2233

merged 40 commits into from
Sep 12, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented Sep 8, 2023

Simple leverage e2e additions

update: Also includes a fix in GetAccountPosition

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2233 (59fb3cc) into main (7f05ad4) will decrease coverage by 5.15%.
Report is 217 commits behind head on main.
The diff coverage is 81.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2233      +/-   ##
==========================================
- Coverage   75.38%   70.24%   -5.15%     
==========================================
  Files         100      168      +68     
  Lines        8025    12623    +4598     
==========================================
+ Hits         6050     8867    +2817     
- Misses       1589     3163    +1574     
- Partials      386      593     +207     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
cmd/ibc_denom/main.go 0.00% <0.00%> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
util/sdkutil/msg.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/grpc_query.go 59.18% <ø> (ø)
x/incentive/keeper/hooks.go 50.00% <ø> (ø)
x/incentive/keeper/invariants.go 0.00% <ø> (ø)
x/incentive/keeper/iter.go 84.90% <ø> (ø)
x/incentive/keeper/keeper.go 75.00% <ø> (ø)
... and 51 more

... and 84 files with indirect coverage changes

@toteki toteki marked this pull request as ready for review September 12, 2023 12:46
@toteki toteki requested a review from a team as a code owner September 12, 2023 12:46
@toteki
Copy link
Member Author

toteki commented Sep 12, 2023

Was running into a few problems with the suite, so I removed some of the improvements I was trying to make (such as non-validator accounts to run transactions)

Now we have simple leverage transactions and a gov proposal. I might add a few more today, but I'lll revert if they run into problems since we're short on time.

tests/e2e/e2e_test.go Outdated Show resolved Hide resolved
@gsk967
Copy link
Collaborator

gsk967 commented Sep 12, 2023

We used validators accounts for signing because those accounts have more voting power when submit the votes to gov proposals @toteki

Co-authored-by: kosegor <30661385+kosegor@users.noreply.github.com>
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few suggestions. Let's add leverage prefix to the related methods and avoid 30s wait time (event if it's in "eventually" call)

tests/e2e/e2e_leverage_test.go Outdated Show resolved Hide resolved
tests/e2e/e2e_leverage_test.go Outdated Show resolved Hide resolved
tests/e2e/e2e_test.go Outdated Show resolved Hide resolved
tests/e2e/e2e_test.go Outdated Show resolved Hide resolved
@toteki toteki added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit fbbbbc3 Sep 12, 2023
25 checks passed
@toteki toteki deleted the adam/e2e branch September 12, 2023 17:02
facundomedica pushed a commit that referenced this pull request Oct 30, 2023
* file

* mimic egor PR #2232

* leverage execute fxns

* comment

* shorten functions

* ++

* const

* add initial balances

* leverage gov setup

* special assets pair gov setup

* initial leverage supply

* lint

* fix

* fix exceed max supply

* ++

* fix

* account tools

* ++

* revert accunt tools

* revert extra balances

* --

* --

* --

* fix

* do not require historic medians for leverage e2e

* suggestion++

Co-authored-by: kosegor <30661385+kosegor@users.noreply.github.com>

* add special pairs to e2e

* fix spelling of undercollateralized

* fix empty description

* modify amounts

* keeper tests with special pairs - AND A FIX

* rename suite functions

* change eventually to 5sec

* suggestion++

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* remove eventually

* modify gov proposal (sets don't loop assets)

---------

Co-authored-by: kosegor <30661385+kosegor@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants