Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oracle): avg params storage. #2260

Merged
merged 7 commits into from
Sep 22, 2023
Merged

fix(oracle): avg params storage. #2260

merged 7 commits into from
Sep 22, 2023

Conversation

robert-zaremba
Copy link
Member

Description

  • v6.1 upgrade handler with code to set AvgParams
  • remove the v6.0.2 fallback to use default AvgParams
  • fix the key scheme by moving the AvgParams store key from params.go (which is dedicated for the x/param spaces) to keys.go.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #2260 (726fbb2) into main (7f05ad4) will decrease coverage by 4.99%.
Report is 239 commits behind head on main.
The diff coverage is 83.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
- Coverage   75.38%   70.40%   -4.99%     
==========================================
  Files         100      168      +68     
  Lines        8025    12644    +4619     
==========================================
+ Hits         6050     8902    +2852     
- Misses       1589     3143    +1554     
- Partials      386      599     +213     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
cmd/ibc_denom/main.go 0.00% <0.00%> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
util/sdkutil/msg.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/bond.go 92.50% <ø> (ø)
x/incentive/keeper/genesis.go 40.90% <ø> (ø)
x/incentive/keeper/grpc_query.go 59.18% <ø> (ø)
x/incentive/keeper/hooks.go 50.00% <ø> (ø)
x/incentive/keeper/invariants.go 0.00% <ø> (ø)
... and 49 more

... and 86 files with indirect coverage changes

x/oracle/types/keys.go Outdated Show resolved Hide resolved
x/oracle/keeper/migrations.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-zaremba robert-zaremba requested a review from a team as a code owner September 21, 2023 17:31
@robert-zaremba robert-zaremba added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit e1cb452 Sep 22, 2023
26 checks passed
@robert-zaremba robert-zaremba deleted the robert/oracle-avg-fix branch September 22, 2023 01:23
facundomedica pushed a commit that referenced this pull request Oct 30, 2023
* fix(oracle): v6.1 upgrade with setting missing oracle avg price params

* oracle: use avg params from the store

* set correct AvgParams prefix key

* fix

* review

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants