fix: fix the auction creation in every end block #2536
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
| if a == nil { | ||
| return k.initNewAuction(id+1, []sdk.Coin{}) | ||
| } | ||
| if !a.EndsAt.After(now) { | ||
| if a.EndsAt.After(now) { |
There was a problem hiding this comment.
we need collect rewards after the auction complete
There was a problem hiding this comment.
No, this is good. The finalize auction does 2 things:
- settles the current auction
- collects fees for the next auction
This should be done only AFTER the current auction.
There was a problem hiding this comment.
in every end block of auction module, it is creating new auction record
| if a == nil { | ||
| return k.initNewAuction(id+1, []sdk.Coin{}) | ||
| } | ||
| if !a.EndsAt.After(now) { | ||
| if a.EndsAt.After(now) { |
There was a problem hiding this comment.
No, this is good. The finalize auction does 2 things:
- settles the current auction
- collects fees for the next auction
This should be done only AFTER the current auction.
* fix: fix the auction creation in every block * ++ * set auction id 0 on query
* testing: set auction params for the feature testnet * fix: fix the auction creation in every end block (#2536) * fix: fix the auction creation in every block * ++ * set auction id 0 on query * fix: fix the rewards collects for bid (#2539) * fix the amount collect to reward auction fee collector * added rewards info for toAuctionCheck * fix the grpc of miss counter api * revert test params * update the changelog --------- Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Description
closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...