Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ibc #2556

Merged
merged 3 commits into from
Jun 20, 2024
Merged

chore: bump ibc #2556

merged 3 commits into from
Jun 20, 2024

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented Jun 20, 2024

Description

Summary by CodeRabbit

  • Dependency Updates

    • Updated Price Feeder component to use a newer version (v7.6.0).
    • Updated dependency github.com/cosmos/ibc-go/v7 to v7.6.0.
  • Test Improvements

    • Modified validation logic in end-to-end tests to check for a more specific string in the output buffer.

@robert-zaremba robert-zaremba requested a review from a team as a code owner June 20, 2024 10:01
Copy link
Contributor

coderabbitai bot commented Jun 20, 2024

Walkthrough

This update incorporates dependency updates and a change in validation logic. Specifically, the version for github.com/cosmos/ibc-go/v7 is updated from v7.5.1 to v7.6.0 in go.mod, affecting the Price Feeder component. Additionally, the E2E test suite now validates output buffer content differently during the IBC packet sending process.

Changes

File Change Summary
README.md Noted the version update for the Price Feeder component and confirmed no changes to exported or public entities.
go.mod Updated github.com/cosmos/ibc-go/v7 from v7.5.1 to v7.6.0.
tests/e2e/setup/utils.go Modified buffer validation logic in the SendIBC function within E2ETestSuite, changing the string check from "bad packet in rate limit's SendPacket" to "must not exceed".

Sequence Diagram(s)

Generating sequence diagrams is not applicable as the changes are primarily version updates and a minor adjustment in test logic.

Poem

🐇 In the realm of code so grand,
A tweak emerges, a change at hand.
Dependencies updated with care and grace,
Ensuring the Price Feeder keeps its pace.
E2E tests now check anew,
Buffers validate, like morning dew.
In this journey, changes flow,
The code evolves, onward we go! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.77%. Comparing base (7f05ad4) to head (0c66700).
Report is 504 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2556       +/-   ##
===========================================
- Coverage   75.38%   62.77%   -12.62%     
===========================================
  Files         100      275      +175     
  Lines        8025    15969     +7944     
===========================================
+ Hits         6050    10024     +3974     
- Misses       1589     5171     +3582     
- Partials      386      774      +388     

see 239 files with indirect coverage changes

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8f38a61 and 0cf1b74.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (2)
  • README.md (1 hunks)
  • go.mod (1 hunks)
Files skipped from review due to trivial changes (1)
  • go.mod
Additional context used
LanguageTool
README.md

[uncategorized] ~20-~20: The adjective “market-driven” is spelled with a hyphen. (DRIVEN_HYPHEN)
Context: ...ally determined interest rates based on market driven conditions. As a cross chain DeFi proto...


[grammar] ~26-~26: You’ve repeated a verb. Did you mean to only write one of them? (REPEATED_VERBS)
Context: ...ble of Contents](#table-of-contents) - Releases - [Release Compatibility Matrix](#release-compatib...


[uncategorized] ~76-~76: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...ld the binary from source on the server machine you probably don't need any change. Bui...


[uncategorized] ~77-~77: A comma may be missing after the conjunctive/linking adverb ‘However’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ...reated as a part of the build process. However when you download a binary from GitHub,...


[grammar] ~114-~114: Did you mean “installing”? Or maybe you should add a pronoun? In active voice, ‘require’ + ‘to’ takes an object, usually a pronoun. (ALLOW_TO)
Context: ...e recommend to use RocksDB. It requires to install rocksdb system libraries. We plan to ...


[uncategorized] ~115-~115: Possible missing article found. (AI_HYDRA_LEO_MISSING_A)
Context: ...b` system libraries. We plan to migrate newer version of badgerdb, which brings lot o...


[grammar] ~115-~115: An article may be missing. (BUNCH_OF)
Context: ...newer version of badgerdb, which brings lot of improvements and simplifies the setup. ...

Additional comments not posted (1)
README.md (1)

67-68: Update the IBC version in the compatibility matrix to match the new version.

This change is consistent with the PR's objective to update the IBC version. It's crucial to ensure that all other related documentation and configurations across the project are updated to reflect this change.

@robert-zaremba robert-zaremba added this pull request to the merge queue Jun 20, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0cf1b74 and 0c66700.

Files selected for processing (1)
  • tests/e2e/setup/utils.go (1 hunks)
Additional comments not posted (1)
tests/e2e/setup/utils.go (1)

145-145: Updated the output validation string to check for "must not exceed" instead of "bad packet in rate limit's SendPacket".

Ensure that this new error message accurately reflects the conditions under which the test is expected to fail, and that it aligns with the updated IBC version's error reporting.

Merged via the queue into main with commit 0da6ee7 Jun 20, 2024
25 of 28 checks passed
@robert-zaremba robert-zaremba deleted the robert/ibc-7.6 branch June 20, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants