-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump ibc #2556
chore: bump ibc #2556
Conversation
WalkthroughThis update incorporates dependency updates and a change in validation logic. Specifically, the version for Changes
Sequence Diagram(s)Generating sequence diagrams is not applicable as the changes are primarily version updates and a minor adjustment in test logic. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2556 +/- ##
===========================================
- Coverage 75.38% 62.77% -12.62%
===========================================
Files 100 275 +175
Lines 8025 15969 +7944
===========================================
+ Hits 6050 10024 +3974
- Misses 1589 5171 +3582
- Partials 386 774 +388 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
Files selected for processing (2)
- README.md (1 hunks)
- go.mod (1 hunks)
Files skipped from review due to trivial changes (1)
- go.mod
Additional context used
LanguageTool
README.md
[uncategorized] ~20-~20: The adjective “market-driven” is spelled with a hyphen. (DRIVEN_HYPHEN)
Context: ...ally determined interest rates based on market driven conditions. As a cross chain DeFi proto...
[grammar] ~26-~26: You’ve repeated a verb. Did you mean to only write one of them? (REPEATED_VERBS)
Context: ...ble of Contents](#table-of-contents) - Releases - [Release Compatibility Matrix](#release-compatib...
[uncategorized] ~76-~76: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...ld the binary from source on the server machine you probably don't need any change. Bui...
[uncategorized] ~77-~77: A comma may be missing after the conjunctive/linking adverb ‘However’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ...reated as a part of the build process. However when you download a binary from GitHub,...
[grammar] ~114-~114: Did you mean “installing”? Or maybe you should add a pronoun? In active voice, ‘require’ + ‘to’ takes an object, usually a pronoun. (ALLOW_TO)
Context: ...e recommend to use RocksDB. It requires to installrocksdb
system libraries. We plan to ...
[uncategorized] ~115-~115: Possible missing article found. (AI_HYDRA_LEO_MISSING_A)
Context: ...b` system libraries. We plan to migrate newer version of badgerdb, which brings lot o...
[grammar] ~115-~115: An article may be missing. (BUNCH_OF)
Context: ...newer version of badgerdb, which brings lot of improvements and simplifies the setup. ...
Additional comments not posted (1)
README.md (1)
67-68
: Update the IBC version in the compatibility matrix to match the new version.This change is consistent with the PR's objective to update the IBC version. It's crucial to ensure that all other related documentation and configurations across the project are updated to reflect this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tests/e2e/setup/utils.go (1 hunks)
Additional comments not posted (1)
tests/e2e/setup/utils.go (1)
145-145
: Updated the output validation string to check for "must not exceed" instead of "bad packet in rate limit's SendPacket".Ensure that this new error message accurately reflects the conditions under which the test is expected to fail, and that it aligns with the updated IBC version's error reporting.
Description
Summary by CodeRabbit
Dependency Updates
Price Feeder
component to use a newer version (v7.6.0
).github.com/cosmos/ibc-go/v7
tov7.6.0
.Test Improvements