Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/cometbft/cometbft-db from 0.12.0 to 0.14.0 #2588

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 12, 2024

Bumps github.com/cometbft/cometbft-db from 0.12.0 to 0.14.0.

Release notes

Sourced from github.com/cometbft/cometbft-db's releases.

v0.14.0

📖 CHANGELOG

v0.13.0

📖 CHANGELOG

Changelog

Sourced from github.com/cometbft/cometbft-db's changelog.

v0.14.0

Aug 9, 2024

This release reinstates boltdb and cleveldb as deprecated backend types. Please note that we discourage the use of them, as we plan to discontinue support in a future release.

DEPENDENCIES

  • reinstate BoltDB and ClevelDB as backend DBs (#177)

v0.13.0

Aug 2, 2024

This release:

  • changes the contract of the Iterator Key() and Value() APIs. Namely, the caller is now responsible for creating a copy of their returned value if they want to modify it.
  • removes support for boltDB and clevelDB, which were marked as deprecated in release v0.12.0.

BREAKING CHANGES

  • removed deprecated boltdb and cleveldb (#155)

FEATURES

  • Iterator Key and Value APIs now return an object that must be copied before use (#168)
Commits
  • 4d1c572 Release v0.14.0 (#178)
  • 9db1a44 Reinstate BoltDB and ClevelDB as backend DBs (#177)
  • a79d349 Update v0.13.0 Changelog (#176)
  • 4206c01 build(deps): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 (#173)
  • fa53f97 build(deps): bump docker/setup-buildx-action from 3.4.0 to 3.6.1 (#174)
  • 66f1cd5 build(deps): bump docker/login-action from 3.2.0 to 3.3.0 (#171)
  • 73ce493 updated changelog for release v0.13.0 (#172)
  • 8182c1c Update cometbft-db Go version to 1.22.5 (#169)
  • 8ff6942 feat!: Iterator Key() and Value() no longer return a copy (#168)
  • 20b4a09 build(deps): bump docker/setup-buildx-action from 3.3.0 to 3.4.0 (#167)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • Chores
    • Updated several dependency versions to ensure compatibility and introduce potential enhancements and fixes.
    • Added a new indirect dependency for improved functionality.
    • Updated the Go version in the GitHub Actions workflow for enhanced compatibility and performance during analysis.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Copy link
Contributor

coderabbitai bot commented Aug 12, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates to the go.mod file for the github.com/umee-network/umee/v6 module involve upgrading various dependencies to newer versions. Key libraries, including cometbft-db, cockroachdb/errors, and sentry-go, have received significant version enhancements. These changes aim to improve performance, fix bugs, and ensure compatibility with the latest features from these libraries, alongside the addition of a new indirect dependency on cockroachdb/fifo. Additionally, the GitHub Actions workflow has been updated to use Go version 1.22.

Changes

Files Change Summary
go.mod Upgrade github.com/cometbft/cometbft-db from v0.12.0 to v0.14.0
Upgrade github.com/cockroachdb/errors from v1.11.1 to v1.11.3
Upgrade github.com/cockroachdb/pebble from v1.1.0 to v1.1.1
Upgrade github.com/getsentry/sentry-go from v0.23.0 to v0.27.0
Add new indirect dependency github.com/cockroachdb/fifo at a specific commit
.github/workflows/codeql-analysis.yml Update go-version from 1.21 to 1.22 for CodeQL analysis job

Sequence Diagram(s)

(No diagrams generated as the changes do not represent a new feature or a complex control flow.)

Poem

In the meadow where rabbits play,
New versions hop in, brightening the day!
With each upgrade, we leap and cheer,
Bugs fixed and features near! 🐇✨
Let's welcome the changes, oh what delight,
As we scurry along, into the night! 🌙


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2acc4a7 and 82d8bd9.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (4 hunks)
Additional comments not posted (5)
go.mod (5)

12-12: Verify compatibility and deprecation warnings for github.com/cometbft/cometbft-db.

The update reinstates deprecated backend types, which are planned to be discontinued in the future. Ensure that the codebase does not rely on these deprecated types and that the update is compatible.


69-69: Verify update for github.com/cockroachdb/errors.

This minor version update may include bug fixes or improvements. Ensure that it does not introduce any breaking changes to the codebase.

Verification successful

No direct usage of github.com/cockroachdb/errors found in the codebase.

The dependency github.com/cockroachdb/errors is not directly imported in any Go files, suggesting it's an indirect dependency. The update to version v1.11.3 is unlikely to introduce breaking changes to the codebase.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that `github.com/cockroachdb/errors` update does not introduce breaking changes.

# Test: Check for any breaking changes in the changelog or release notes. Expect: No breaking changes.
rg --type markdown 'breaking changes' --files-with-matches | xargs rg 'cockroachdb/errors'

Length of output: 90


Script:

#!/bin/bash
# Description: Search for usage of `github.com/cockroachdb/errors` in the codebase.

# Find all Go files that import `github.com/cockroachdb/errors`.
rg 'import.*"github.com/cockroachdb/errors"' --type go -A 5

Length of output: 61


70-70: Verify necessity and compatibility of github.com/cockroachdb/fifo.

This new indirect dependency should be assessed for its necessity and compatibility with the existing codebase.


72-72: Verify update for github.com/cockroachdb/pebble.

This patch version update may include bug fixes or performance improvements. Ensure that it does not introduce any breaking changes to the codebase.


102-102: Verify update for github.com/getsentry/sentry-go.

This update may include new features or fixes. Ensure that it does not introduce any breaking changes and assess if any new features should be utilized.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cometbft/cometbft-db-0.14.0 branch 2 times, most recently from e20b7ba to 30d460a Compare August 13, 2024 11:01
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 82d8bd9 and 30d460a.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • go.mod

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cometbft/cometbft-db-0.14.0 branch from 30d460a to c777952 Compare August 14, 2024 13:24
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 30d460a and c777952.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • go.mod

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cometbft/cometbft-db-0.14.0 branch 2 times, most recently from 36ef8ab to 00d8f3b Compare August 14, 2024 14:00
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c777952 and 00d8f3b.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • go.mod

Bumps [github.com/cometbft/cometbft-db](https://github.com/cometbft/cometbft-db) from 0.12.0 to 0.14.0.
- [Release notes](https://github.com/cometbft/cometbft-db/releases)
- [Changelog](https://github.com/cometbft/cometbft-db/blob/main/CHANGELOG.md)
- [Commits](cometbft/cometbft-db@v0.12.0...v0.14.0)

---
updated-dependencies:
- dependency-name: github.com/cometbft/cometbft-db
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cometbft/cometbft-db-0.14.0 branch from 00d8f3b to da73073 Compare August 14, 2024 14:12
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 00d8f3b and 190cdd5.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • go.mod

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 190cdd5 and e758fb4.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (2)
  • .github/workflows/codeql-analysis.yml (1 hunks)
  • go.mod (4 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/codeql-analysis.yml
Files skipped from review as they are similar to previous changes (1)
  • go.mod

@gsk967 gsk967 self-requested a review August 18, 2024 16:51
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.55%. Comparing base (7f05ad4) to head (23ca657).
Report is 544 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2588       +/-   ##
===========================================
- Coverage   75.38%   62.55%   -12.84%     
===========================================
  Files         100      275      +175     
  Lines        8025    16036     +8011     
===========================================
+ Hits         6050    10032     +3982     
- Misses       1589     5231     +3642     
- Partials      386      773      +387     

see 239 files with indirect coverage changes

@gsk967
Copy link
Collaborator

gsk967 commented Aug 20, 2024

Note: DNM there are some tests are failing

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 10, 2024

A newer version of github.com/cometbft/cometbft-db exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@gsk967
Copy link
Collaborator

gsk967 commented Nov 1, 2024

Closing this PR due to this cometbft/cometbft#4369

@gsk967 gsk967 closed this Nov 1, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 1, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/cometbft/cometbft-db-0.14.0 branch November 1, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant