Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get the token price if token is blacklisted also #2615

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Oct 29, 2024

We are getting error when fetching the token price of blacklisted token , this pr will fix that , We only removing the asset from leverage token registry if supply is zero


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • Bug Fixes

    • Removed the restriction on fetching prices for blacklisted tokens, allowing for improved price retrieval processes.
  • Refactor

    • Updated the logic in the TokenPrice method for better handling of token validation scenarios.

@gsk967 gsk967 requested a review from a team as a code owner October 29, 2024 13:20
Copy link
Contributor

coderabbitai bot commented Oct 29, 2024

Walkthrough

The changes in this pull request focus on the TokenPrice method within the Keeper struct in the oracle.go file. The modification involves the removal of the check for blacklisted tokens, allowing the method to continue processing even if a token is blacklisted. This change alters the control flow, impacting how errors are handled in relation to token pricing without modifying any exported or public entity signatures.

Changes

File Path Change Summary
x/leverage/keeper/oracle.go Removed check for blacklisted tokens in TokenPrice method, altering control flow and error handling.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Keeper
    participant TokenService

    Client->>Keeper: Request Token Price
    Keeper->>TokenService: Fetch Token Price
    TokenService-->>Keeper: Return Token Price
    Keeper-->>Client: Return Token Price
Loading

Poem

In the garden where tokens play,
A blacklisted friend can join the fray.
No more checks to hold them back,
Prices flow on a smoother track.
Hops of joy in the code we see,
A brighter path for you and me! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f3d0565 and 2e29fb9.

📒 Files selected for processing (1)
  • x/leverage/keeper/oracle.go (0 hunks)
💤 Files with no reviewable changes (1)
  • x/leverage/keeper/oracle.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gsk967 gsk967 enabled auto-merge October 29, 2024 16:40
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.01%. Comparing base (7f05ad4) to head (2e29fb9).
Report is 542 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2615       +/-   ##
===========================================
- Coverage   75.38%   62.01%   -13.38%     
===========================================
  Files         100      275      +175     
  Lines        8025    19629    +11604     
===========================================
+ Hits         6050    12172     +6122     
- Misses       1589     6685     +5096     
- Partials      386      772      +386     
Files with missing lines Coverage Δ
x/leverage/keeper/oracle.go 59.58% <ø> (-8.25%) ⬇️

... and 215 files with indirect coverage changes

@gsk967 gsk967 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 38fc85f Oct 30, 2024
24 of 27 checks passed
@gsk967 gsk967 deleted the sai/fix_blacklist_token branch October 30, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants