Make non-master CI build only for repo owner #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying tg-spam with
|
| Latest commit: |
794daae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c5831005.tg-spam.pages.dev |
| Branch Preview URL: | https://paskal-fix-ci.tg-spam.pages.dev |
|
The ability to build (and push) images from a non-master branch is practically important to provide a testing image prior to merging into master, so it can be tested by the end users in their environment. At the same time, this should be something only I can do, but breaking CI for all external PRs is not a good thing either. So, we need a better way of doing that. Maybe just a make target to run it manually instead of a CI task? |
|
maybe we can add a check for my user name here, and skip if not matching? |
paskal
changed the title
|
Done, I thought about it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was introduced in #186.