fix: make ring outline determine thickness as a proportion of radius #178
Conversation
| @@ -16,23 +16,13 @@ in vec2 vFromCenter; | |||
| out vec4 fragColor; | |||
|
|
|||
| void main() { | |||
| float thickness = max(fPixelLength, min(0.1, fPixelLength * uOutline * uPixelRatio)); | |||
| float antialias = min(thickness, fPixelLength * 1.5); | |||
There was a problem hiding this comment.
you removed the antialias now, that will make the rendering jaggy, should this not be added back with the new thickness checked?
There was a problem hiding this comment.
How would we implement it in the new context of using a proportion instead of a particular pixel length?
There was a problem hiding this comment.
do we not compute the thickness value with the ratio? could we not pass that along withthe 0.5 offset?
There was a problem hiding this comment.
This is in the ring shader, I assume this applies to the circle node as well? What about the other shapes? How does the thickness work for those?
There was a problem hiding this comment.
This change only affects the ring type node. I have not made any changes to other shapes.
There was a problem hiding this comment.
right, but the question is should we, i assume right now the other shapes are doing what they did before, so pixel locked the outline width. All shapes/nodes should behave the same otherwise it will be very confusing to keep track of the differences.
No description provided.